search

youseedk / dna

CSS framework for yousee.dk
ISC License
6 stars 6 forks source link

Change icon color #289

Open OVA-robin opened 3 years ago

OVA-robin commented 3 years ago

All icons on yousee.dk should be changed to color #191919

dechowdev commented 3 years ago

This is a tall order - if you are asking for all icon colors to be changed on YouSee.dk

We can give default styling to the icons that are in the DNA framework as #191919 - but the change can only happen "globally" when users implement the icons as-is :)

I mention this because it needs to be communicated in each squad, that this is the default icon color, etc. - we can only implement, the happy defaults (if that makes sense)

But let's do it and make a task for getting this done :)

OVA-robin commented 3 years ago

Well change icons colors in the DNA Framework to #191919 and to change all other icons will be an other task.

laukondrup commented 3 years ago

I am talking with @grandorf about how we can do this.

There is a huge issue (technically). While this is easy to implement, it's only one line. It would overrule any color changes made by our users. So if you chose your icon to be YouSee digital green then this would turn them all (using DNA) into this new black.

This is due to the #ys-specificty added to all our selectors so it would be a breaking change where people have to add !important to all their color changes which we want to avoid.

grandorf commented 3 years ago

We can change the DNA components to this color. Also, if devs change their default font color to #191919 (as they should) on all projects then most icons will follow this color unless the color has been set to another color on purpose. We should not force all icons to this color. Some places they are green or white with a purpose.