search

youshido-php / GraphQL

Pure PHP realization of GraphQL protocol
MIT License
710 stars 106 forks source link

Can extract the Parser as a standalone package? #243

Open leoloso opened 4 years ago

leoloso commented 4 years ago

Hi! I'm currently using only the Parser from Youshido, and not the full GraphQL server. I use it to power another GraphQL server in PHP which I'm developing, GraphQL by PoP (I'm in the process of launching it, soon).

Would it be possible to extract the Parser as a standalone solution, and then have the Youshido server simply include it as a dependency?

I know that this is not really needed, but it makes the whole solution nicer and cleaner, and this parser works really well as a standalone solution. (I also tried the one from webonyx, but that one doesn't work in my project, because it has a hard dependency on its own schema)

Also, I've seen that this package is looking for new maintainers, and I wonder if it would be easier to find them for smaller tasks. Then, someone could become the maintainer just for the parser and keep it updated with all the upcoming changes to the GraphQL spec, which are already happening (eg: the "&" symbol to declare all implemented interfaces).

Thanks

Jalle19 commented 4 years ago

Sounds like a good idea, I've seen similar discussions in other implementations (everyone needs a lexer + parser and it's cumbersome to re-implement the wheel all the time).

leoloso commented 4 years ago

That would be wonderful! How to kick-start this development? Should I try to do it? Or anyone else can take care of it? (I'm not experienced with Youshido's codebase, just scratching the surface, and this issue will most likely involve changes in its architecture...)