search

youshido-php / GraphQL

Pure PHP realization of GraphQL protocol
MIT License
710 stars 107 forks source link

Refactored for PHP 8 #255

Open Matys333 opened 6 months ago

Matys333 commented 6 months ago

We were using this package in our warehouse system application and we wanted to upgrade to Symfony 6.4, but we did not want to use any other package, so we forked it and refactored it along with the GraphQLBundle (there is PR as well). Refactored the code to PHP 8 standards, added type declarations and various fixes that came along with it. It has been now tested for some time on our live application, which deals with tons of requests and everything works fine, but I'm not saying there cannot be some problems for others. With that we would be open to maintain it from now on, please let me know. Thanks

Jalle19 commented 6 months ago

I'm certainly open to letting you maintain this project if you find it useful. @viniychuk is the only one (I think) who can add new collaborators though.

Jalle19 commented 5 months ago

Ping @viniychuk

Jalle19 commented 5 months ago

I may have the project owner's email address somewhere, I'll see if I can get a hold of him that way.

Matys333 commented 5 months ago

Thanks @Jalle19.

Jalle19 commented 3 months ago

I can't reach the original maintainer anymore. I think it's probably best if you fork this and publish it under another name to Composer.

viniychuk commented 3 months ago

Hey there folks,

All of this was in spam. Adding you as a collaborator and sharing the permissions to add more!

On Aug 30, 2024, at 8:16 AM, Sam Stenvall @.***> wrote:

I can't reach the original maintainer anymore. I think it's probably best if you fork this and publish it under another name to Composer.

— Reply to this email directly, view it on GitHub https://github.com/youshido-php/GraphQL/pull/255#issuecomment-2321049636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKYZ5MWJULGBYQRTGDIZILZUBPCFAVCNFSM6AAAAABIQPRIJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRRGA2DSNRTGY. You are receiving this because you were mentioned.

Jalle19 commented 3 months ago

Awesome!

Jalle19 commented 3 months ago

@Matys333 feel free to merge

Matys333 commented 2 months ago

Hey guys, sorry, I was off past two weeks. @viniychuk The invitation has expired, can you please send it again, and for the bundle as well? Thanks! Also, I'll have tests ready soon too, will merge after that and everything else with some changes to the readme, so after everything is ready 100%.

Jalle19 commented 2 months ago

I don't seem to have the ability to add maintainers, even though @viniychuk said he'd add that :shrug: Let's hope he responds again