Fix #47: Not able to inject a custom schema service

youshido-php / GraphQLBundle

Pure PHP implementation of GraphQL Server – Symfony Bundle

MIT License

284 stars 44 forks source link

Fix #47: Not able to inject a custom schema service #48

Closed mloureiro closed 7 years ago

mloureiro commented 7 years ago

This PR attempts to fix #47

By adding a new optional configuration parameter (graphql.schema_service) and improving the way to load the service.

No tests were added since there are none.

seb2411 commented 7 years ago

Any plan to merge this PR ?

viniychuk commented 7 years ago

@MLoureiro @seb2411 We merged this PR but we're going to replace it with a new logic that would support only Service type of schema injection and we'll move all the logic from the controller to the bundle internal class. schema_service name of config will remain intact though.

iainmckay commented 7 years ago

Could you tag a new version for this?