search

youshido-php / GraphQLBundle

Pure PHP implementation of GraphQL Server – Symfony Bundle
MIT License
284 stars 44 forks source link

symfony 5 support #81

Closed Bast1onCZ closed 3 years ago

Bast1onCZ commented 4 years ago

I changed the necessary things to be able to run the library in symfony 5. Please publish this package.

arendjantetteroo commented 4 years ago

Works for me.

Complains about 2 more items regarding the controllers. The "Youshido\GraphQLBundle\Controller\GraphQLController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

and

The "Youshido\GraphQLBundle\Controller\GraphQLExplorerController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

Bast1onCZ commented 4 years ago

You are right. Please fork my repo and create a pull request

logosur commented 3 years ago

Hello,

Nobody taking this pull request?

Regards.