feat: make external links in navbar open in new tab

yousinix / portfolYOU

A beautiful portfolio Jekyll theme that works with GitHub Pages.

https://yousinix.github.io/portfolYOU

MIT License

987 stars 594 forks source link

feat: make external links in navbar open in new tab #77

Closed Avery2 closed 3 years ago

Avery2 commented 3 years ago

Continually adds target="_blank" if the link in the navbar is created by external_url. I don't know if this is a feature you want or not, but my use-case was adding a link to my GitHub, which I didn't want to replace the tab that was my website:

---
title: <i class="fab fa-github"></i>
external_url: https://github.com/Avery2
weight: 99
---

yousinix commented 3 years ago

I don't think that everyone will like this behavior, we better stick with the default behavior, used across most themes. Thanks for your time tho! 😃