search

yousseb / meld

Meld for macOS
https://yousseb.github.io/meld/
GNU General Public License v2.0
2.28k stars 119 forks source link

Meld doesn't quit properly on Mojave 10.14.2 #75

Open michalgutowski opened 5 years ago

michalgutowski commented 5 years ago

I've noticed that after closing Meld (cmd+q), its processes are still running - as a result it's not possible to open Meld app again. I can only open it again if I first kill two Meld related processes in the terminal.

This only happens when you actually compared some files or created a blank comparison. When you simply open Meld and quit it right away there is no issue. I'm running Meld 3.19.2 (r3).

yanli0303 commented 5 years ago

Same here, exactly same OS version and Meld version, exactly same issue.

yousseb commented 5 years ago

I'll look into it this weekend. Thanks for the report.

yousseb commented 5 years ago

Please check on this build https://github.com/yousseb/meld/releases/tag/osx-13

michalgutowski commented 5 years ago

Looks better. With 3.19.2 (r4) I can re-launch Meld without problems. However I can still see Meld process running even after quitting:

$ ps -ef | grep -i [m]eld 501 32935 1 0 10:38AM ?? 0:00.02 /Applications/Meld.app/Contents/MacOS/Meld

To keep things nice and clean I should still kill that process manually.

yousseb commented 5 years ago

Humm.. Not sure what is happening at your end. I'm not getting this (I used to in the previous version). Going to be harder to debug..

yanli0303 commented 5 years ago

@yousseb This issue is gone on my machine, macOS Mojave 10.14.2 (18C54). Thanks for the quick fix!

michalgutowski commented 5 years ago

@yousseb - try with these steps:

  1. open Meld
  2. check ps -ef - you will have one Meld process running
  3. crate blank file comparision
  4. check ps -ef - you will have two Meld processes running
  5. quit Meld
  6. check ps -ef - you will have one Meld process running
yousseb commented 5 years ago

Are you guys still getting this issue? If you are, give this build a shot. I'm unable to fully reproduce (sometimes it happens, but it hasn't occurred to me in a long while.) This build is hopefully better. https://github.com/yousseb/meld/releases/tag/osx-15

nobodo commented 5 years ago

Still happens to me. Opening Meld will spawn two meld processes and quitting just kills only one of them (the one that was created first, observation based on the pid)

huangw5 commented 5 years ago

+1. This is still happening with 3.19.2 (r6) on macOS 10.14.5

jtan189 commented 4 years ago

This is still happening for me using Meld v3.19.2 on macOS 10.15.3.

I'm invoking Meld using git diff-tool and this config:

[difftool "meld"]
  cmd = open -W  -n -a Meld --args $(cd $(dirname \"$LOCAL\") && pwd)/$(basename \"$LOCAL\") $(cd $(dirname \"$REMOTE\") && pwd)/$(basename \"$REMOTE\")
  trustExitCode = true

I noticed that I can bypass the issue if I first close all Meld diffing instances with Command-W, and only then quit the Meld app with Command-Q. If I use Command-Q without closing all diffing instances (even after saving any changes), I find zombie Meld processes.