youthweb / php-youthweb-api

🔌 PHP Youthweb API is an object-oriented wrapper for PHP of the Youthweb API.
GNU General Public License v3.0
3 stars 1 forks source link

Replace VoidVache with NullCacheItemPool #27

Closed Art4 closed 1 year ago

Art4 commented 1 year ago

This will remove the dependency to external VoidCache library and allows us to trigger errors, if no cache pool was provided.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.75% and project coverage change: -0.36 :warning:

Comparison is base (2074b1f) 100.00% compared to head (b2cc3dd) 99.64%.

:exclamation: Current head b2cc3dd differs from pull request most recent head ac4e883. Consider uploading reports for the commit ac4e883 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v0.x #27 +/- ## ============================================= - Coverage 100.00% 99.64% -0.36% - Complexity 75 94 +19 ============================================= Files 10 12 +2 Lines 242 284 +42 ============================================= + Hits 242 283 +41 - Misses 0 1 +1 ``` | [Impacted Files](https://codecov.io/gh/youthweb/php-youthweb-api/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb) | Coverage Δ | | |---|---|---| | [src/Cache/NullCacheItemPool.php](https://codecov.io/gh/youthweb/php-youthweb-api/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb#diff-c3JjL0NhY2hlL051bGxDYWNoZUl0ZW1Qb29sLnBocA==) | `96.87% <96.87%> (ø)` | | | [src/Authentication/NativeAuthenticator.php](https://codecov.io/gh/youthweb/php-youthweb-api/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb#diff-c3JjL0F1dGhlbnRpY2F0aW9uL05hdGl2ZUF1dGhlbnRpY2F0b3IucGhw) | `100.00% <100.00%> (ø)` | | | [src/Cache/NullCacheItem.php](https://codecov.io/gh/youthweb/php-youthweb-api/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb#diff-c3JjL0NhY2hlL051bGxDYWNoZUl0ZW0ucGhw) | `100.00% <100.00%> (ø)` | | | [src/Client.php](https://codecov.io/gh/youthweb/php-youthweb-api/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb#diff-c3JjL0NsaWVudC5waHA=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=youthweb)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.