search

youtube / js_mse_eme

js_mse_eme is an externally-published tool that is aimed to test the validity of a browser's HTML5 Media Source Extension and Encrypted Media Extension implementations
Apache License 2.0
91 stars 58 forks source link

EME: PlayReadySupport check for maybe and probably #11

Closed calvaris closed 8 years ago

calvaris commented 8 years ago

Since probably is more restrictive than maybe if a test accepts maybe it should accept probably too.

calvaris commented 8 years ago

This comes from closing https://github.com/youtube/js_mse_eme/pull/10.

I understand that the proposed solution might not be ideal, that's why I changed the angle, at least for the PlayReady test, which is the one we are having trouble with.

I hope this solution could be more acceptable now.

tdedecko commented 8 years ago

Sorry this is changes test expectations. I'm not interested in changing this.

calvaris commented 8 years ago

Man, you might not be interested, but your expectations are wrong and proof of this is that the same test in tip has the right ones. 'probably' is more restrictive than 'maybe' so if you accept the latter you should clearly accept the former. These are certification tests that should pass if you want to certify a device and you can't if the tests are tainted or wrong, as it is the case.

calvaris commented 8 years ago

Any solution that you can suggest?

calvaris commented 8 years ago

Is the solution that I lie and tell that my support is crappier than the one I have to fulfill your test? And then I would fail tip... IMHO, it makes little sense.