search

youtube / js_mse_eme

js_mse_eme is an externally-published tool that is aimed to test the validity of a browser's HTML5 Media Source Extension and Encrypted Media Extension implementations
Apache License 2.0
91 stars 58 forks source link

Add support to loop a test a number of times #14

Closed calvaris closed 7 years ago

calvaris commented 8 years ago

This functionality seems to have been lost with the last merges

calvaris commented 8 years ago

I saw this today: https://github.com/youtube/js_mse_eme/pull/13, I hope this new commit does not always enable loop.

tdedecko commented 8 years ago

Can you add a param instead of overloading the loop param? Maybe 'loopn' or 'loopcount'.

calvaris commented 8 years ago

Sure I can, but how shuld any override the other? Does loop=true always spin forever? Doesn't loop=true spin forever but it is still necessary for loopcount to take effect?

tdedecko commented 8 years ago

loop should override loopcount since it is a switch that can be set on the UI at any time.