search

youtube / js_mse_eme

js_mse_eme is an externally-published tool that is aimed to test the validity of a browser's HTML5 Media Source Extension and Encrypted Media Extension implementations
Apache License 2.0
91 stars 58 forks source link

Support DOMHighResTimeStamp values in Event.timestamp #25

Closed eocanha closed 7 years ago

eocanha commented 7 years ago

This fixes test "51. EventTimestamp" in the 2016 MSE test suite on browsers implementing high resolution timestamps, as specified in[1]. Those timestamps don't count from the epoch, but from the time origin[2].

This new behaviour is different from the specified in DOM4[3], where Event.timestamp is of type DOMTimeStamp and is clearly stated that the epoch is used as reference[4].

Most modern browsers (Firefox, Chrome, Edge and WebKit) have already migrated to high res timestamps.

[1] https://dom.spec.whatwg.org/#interface-event [2] https://w3c.github.io/hr-time/#time-origin [3] https://www.w3.org/TR/domcore/#event [4] https://www.w3.org/TR/domcore/#dom-event-timestamp

tdedecko commented 7 years ago

Thanks for the contribution. Overall, changes should not be made to the 2016 suite since it is finalized at this point. I'll consider a change to 2018 and tip but I would need to follow up on if we are interested in this change.

eocanha commented 7 years ago

Thanks for the explanation, I understand the restriction on already finalized releases. In the meantime we'll resort to revert the usage of high resolution timestamps in our browser.

tdedecko commented 7 years ago

okay. I'll close this pull request.

eocanha commented 7 years ago

Just to clarify it: the code of 2018 and tip tests is different and doesn't have this issue.

tdedecko commented 7 years ago

You're right. I thought I made that change. Thanks for the clarification.