youtube / js_mse_eme

js_mse_eme is an externally-published tool that is aimed to test the validity of a browser's HTML5 Media Source Extension and Encrypted Media Extension implementations
Apache License 2.0
91 stars 58 forks source link

Allow playback of video to be muted (#41) #43

Closed whimboo closed 5 years ago

whimboo commented 5 years ago

Fixes issue #41.

For browsers / platforms where autoplay is blocked due to audio output, allow the start of the playback by just muting the audio channel.

whimboo commented 5 years ago

Is there anyone who could review this PR? Or is such an option not wanted?

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

whimboo commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

whimboo commented 5 years ago

@jiaqzhao thank you for merging the PR. Do you think that you could also cherry-pick for the 2019 branch?

jiaqzhao commented 5 years ago

Thanks for the PR. Yes, I will do that.

whimboo commented 5 years ago

Something I noticed is that it might be good to have the muted flag shown in the "menu" bar too, like next to Loop, or Log.