Refactor and improve animation logic.

youtube / spfjs

A lightweight JS framework for fast navigation and page updates from YouTube

https://youtube.github.io/spfjs/

MIT License

2.24k stars 147 forks source link

Closed nicksay closed 9 years ago

nicksay commented 9 years ago

Make the start state more reliable by delaying for 17ms (1 frame at 60 frames/second) before running the animation.
Refactor the animation logic into separate dedicated functions for clarity: prepare, run, complete.
Store animation-related data in a dedicated object.
Rename a couple DOM methods to better communicate what they do.

nicksay commented 9 years ago

I'm going to split the refactoring and logic changes out from the demo CSS changes so they're isolated.

nicksay commented 9 years ago

Updated this PR to remove the changes to the development demo

nicksay commented 9 years ago

The demo CSS changes are now in #296.

nicksay commented 9 years ago

Extra blank lines removed.

awbraunstein commented 9 years ago

lgtm

nicksay commented 9 years ago

Post-commit associating this with #299.