search

youtube / spfjs

A lightweight JS framework for fast navigation and page updates from YouTube
https://youtube.github.io/spfjs/
MIT License
2.23k stars 147 forks source link

Fix setting "value" attributes. #379

Closed nicksay closed 8 years ago

nicksay commented 8 years ago

When setting an input element's value attribute via el.setAttribute(), the displayed value is not updated, and the original value returned by el.value instead of the new value. To fix this, assign the value attribute both ways.

Also, add tests to catch this problem.

Closes #359.

nicksay commented 8 years ago

PTAL @rviscomi

rviscomi commented 8 years ago

LGTM thanks for the fix