Full body response on onError option for spf.navigate

youtube / spfjs

A lightweight JS framework for fast navigation and page updates from YouTube

https://youtube.github.io/spfjs/

MIT License

2.24k stars 147 forks source link

Full body response on onError option for spf.navigate #402

Closed tchiotludo closed 8 years ago

tchiotludo commented 8 years ago

For now, we just received on simple detail.err string for failed navigate on option onError, I've added a detail.xhr with the full XMLHttpRequest in order to have more detail and responseText for debuging or displaying

DavidCPhillips commented 8 years ago

Whoops, this one slipped a bit.

The changes look good. Could you squash the commits into one? Then we'll go ahead and merge it in.

tchiotludo commented 8 years ago

it's done. Thanks

DavidCPhillips commented 8 years ago

LGTM