youtube / spitfire

A high-performance Python template language
BSD 3-Clause "New" or "Revised" License
404 stars 58 forks source link

Improve test suite runner to fail on errors and track test execution #38

Closed nicksay closed 8 years ago

nicksay commented 8 years ago

This change updates the test suite runner (scripts/crunner.py):

Closes #37

awbraunstein commented 8 years ago

Lol. The tests don't pass so this can't be merged..

lgtm, but we probably need to either fix or disable those tests.

nicksay commented 8 years ago

So strange. This passes on Mac Python 2.7.10 and not Linux Python 2.7.6:

Mac:

$ uname -sr; python -V; make tests &> /dev/null && echo pass || echo fail
Darwin 15.2.0
Python 2.7.10
pass

Linux:

$ uname -sr; python -V; make tests &> /dev/null && echo pass || echo fail
Linux 3.13.0-67-generic
Python 2.7.6
fail

However, it looks to me like the test suite is failing on master as well. I think #39 will fix this.

nicksay commented 8 years ago

I've rebased onto #39 and tests pass now. Once #39 is in, I'll rebase back on master to remove the extra commit.

awbraunstein commented 8 years ago

lgtm