youtube / spitfire

A high-performance Python template language
BSD 3-Clause "New" or "Revised" License
404 stars 58 forks source link

Restore Makefile define + call pattern for cleaning tests #39

Closed nicksay closed 8 years ago

nicksay commented 8 years ago

When running all tests in sequence, removing previously generated files is needed to ensure proper output. A previous cleanup of the Makefile changed targets from:

test_target_one:
  $(call _clean_tests)
  ...
test_target_two:
  $(call _clean_tests)
  ...

to:

test_target_one: clean_tests
test_target_two: clean_tests
  ...

However, this change meant that the new Make dependency order was:

instead of:

To fix this, restore the previous define + call pattern.

Progress on #37

awbraunstein commented 8 years ago

lgtm