search

youtube / youtube-ios-player-helper

Lightweight helper library that allows iOS developers to add inline playback of YouTube videos through a WebView
Other
1.65k stars 683 forks source link

Compare request.URL and originURL using lowercase Strings #377

Closed brol1dev closed 4 years ago

brol1dev commented 4 years ago

Otherwise if an app contains any Uppercasing in its name, we were encountering an issue in which request.URL.host and originURL.host were using different casing even tho the strings were the same and that was making the isEqual comparison fail.

Didn't encounter this issue before because the sample app we test against does not contain Uppercase in its name.

This fixes issue #374.

Amin-Rehman commented 4 years ago

hmm, interesting can still seem to repro the issue despite this fix. Just ran a test against your branch. Can investigate a bit more.