youtube / youtube-ios-player-helper

Lightweight helper library that allows iOS developers to add inline playback of YouTube videos through a WebView
Other
1.64k stars 680 forks source link

iOS 9.0 support. #409

Closed atenasio closed 3 years ago

atenasio commented 4 years ago

Hi,

This lets apps supporting iOS 9.0 upgrade to 1.x series of this pod (WKWebView, etc).

I don't have an older device in front me of me to test but the new codepaths work as expected when forced to run on iOS 13.6.

Do you want this?

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

atenasio commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

denkeni commented 4 years ago

They did not want this, but it does look like there's demand for iOS 9 support (also here). 😉

todd-patterson commented 3 years ago

Hi atenasio, Thank you for your contribution, but we are intentionally no longer supporting iOS 9. Refer to comments in #400 and #402.

atenasio commented 3 years ago

All good, thanks much for maintaining this 🙏