youtubevos / MaskTrackRCNN

MaskTrackRCNN for video instance segmentation based on mmdetection
Apache License 2.0
431 stars 75 forks source link

assertion is always true so remove the parentheses #2

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/youtubevos/MaskTrackRCNN on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./mmdet/models/detectors/base.py:142:9: F631 assertion is always true, perhaps remove parentheses?
        assert(len(imgs) == 1, "only support mini-batch size 1") 
        ^
./mmdet/datasets/ytvos.py:98:30: F821 undefined name 'ExtraAugmentation'
            self.extra_aug = ExtraAugmentation(**extra_aug)
                             ^
1     F631 assertion is always true, perhaps remove parentheses?
1     F821 undefined name 'ExtraAugmentation'
2

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

linjieyangsc commented 5 years ago

LGTM. Thanks for improving the repo!