search

youtype / awscliv2

Wrapper for dockerized AWS CLI v2
https://youtype.github.io/awscliv2/
MIT License
35 stars 5 forks source link

[BUG] Type hinting bug in new 2.0.1 with Python 3.7,3.8 #13

Closed JonasDev1 closed 2 years ago

JonasDev1 commented 2 years ago

Describe the bug With the latest update, type hinting features from python 3.9 have been added, which making the application no longer compatible for Python 3.7 and 3.8.

To Reproduce Steps to reproduce the behavior:

  1. Install 'awscliv2' on < Python3.9
  2. Run the following command ``awsv2 --install```

Problem solving The problem occurs since the refactoring at least in the interactive_process.py. It is related to the typ hinting in method signature with Popen[bytes], which will only beeing supported out of the box since Py3.9. To solve it in 3.7 and 3.8 you can import from __future__ import annotations (See https://github.com/python/typeshed/issues/4948)

vemel commented 2 years ago

Thank you for the report! Will fix today

vemel commented 2 years ago

Fixed and released in 2.0.2. Please let me know if it works as it should.

JonasDev1 commented 2 years ago

Thank you 👍 The cli runs now on Python 3.7 successfully