search

youtype / botocore-stubs

Type annotations and code completion for botocore package
https://youtype.github.io/mypy_boto3_builder/
MIT License
3 stars 3 forks source link

Incorrect typing for `botocore.auth.AUTH_TYPE_MAPS` #8

Closed wRAR closed 9 months ago

wRAR commented 9 months ago

https://github.com/youtype/botocore-stubs/blob/3dc924f458fc4418eae780293b26090133bba468/botocore-stubs/auth.pyi#L124 is incorrect: the dict values are Type[BaseSigner], not BaseSigner.

vemel commented 9 months ago

Thank you! I changed typing of AUTH_TYPE_MAPS and CRT_AUTH_TYPE_MAPS to Dict[str, Type[BaseSigner]].

I also released botocore-stubs 1.32.3.post1 with the fix included. Please update and let me know if it works as it should.

wRAR commented 9 months ago

Thanks! It works correctly now.