youtype / mypy_boto3_builder

Type annotations builder for boto3 compatible with VSCode, PyCharm, Emacs, Sublime Text, pyright and mypy.
https://youtype.github.io/mypy_boto3_builder/
MIT License
544 stars 36 forks source link

Update dynamo conditions to include `name` in AttributeBase #230

Closed fivepapertigers closed 11 months ago

fivepapertigers commented 11 months ago

Notes

Addes the name property to the AttributeBase class (and subclasses)

Addresses #229

Type of change

Checklist

All of these are optional:

Thank you!

vemel commented 11 months ago

Thank you for your contribution! Probably it makes sense to do smth like:

class AttributeBase:
    def __init__(self, name: str) -> None:
        self.name: str

because AttributeBase.name is not a class attribute. Let me know what you think!