search

youvsvirus / youvsvirus-unity

Unity version of the you vs virus game.
GNU General Public License v3.0
1 stars 1 forks source link

Levelsupermarket #106

Closed maccxs closed 4 years ago

maccxs commented 4 years ago

Changes

holke commented 4 years ago

I like this level. I take it most of the pathfinding code is copied and i do not need to review it?

One suggestion: When i start the level i am immediately outside of my house and may directly collide with NPCs. This surprised me the first time i played. I think the experience for the player would be better if we start inside the house and can decide by ourselves when we leave it.

holke commented 4 years ago

I didnt find the counter at first, since du to working on the toilet paper level i was used to looking in the upper left corner. And then i looked in the upper right corner and didnt find it. Took me a long time to look down, and i knew that it had to be there.

What i want to say: Maybe we should not change the position of these counters between levels. Additionally up is better then down. However, there is a supermarket in the upper left corner. Can we put both counters in the upper right corner?

maccxs commented 4 years ago

Ja, können wir, auch die Idee mit dem Spieler im Haus ist gut. Und der Ehekot ist nicht von mir. LOL ai Code

Am 13.05.2020 um 19:17 schrieb holke notifications@github.com:

 I didnt find the counter at first, since du to working on the toilet paper level i was used to looking in the upper left corner. And then i looked in the upper right corner and didnt find it. Took me a long time to look down, and i knew that it had to be there.

What i want to say: Maybe we should not change the position of these counters between levels. Additionally up is better then down. However, there is a supermarket in the upper left corner. Can we put both counters in the upper right corner?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

maccxs commented 4 years ago

Changes

maccxs commented 4 years ago

I finally found the time to review the new commits. I feel a little bad for all the comments that i have, but let me say first: This has gotten really good :) I like the level, i like your ideas for the start screen, and it works without errors. Good work :)

Should be only minor changes though.

In the start screen the "PlayerHousePlayer" Object is within the canvas and the other items (supermarket, toilet roll, pfeil, etc.) are not. Is there a reason for this? If not, lets make either all members of the canvas or none.

Also in start screen: The canvas with the intro text is not centered anymore (as in the other levels). I suppose this is due to the pictures of the house and supermarket in the left hand corner (which i like very much by the way :) ). However, these are rather larger and could also be smaller, which may offer a way to put the canvas back in the middle again. However, if it is not possible to fit everything and have the canvas in the middle, then dont do it, we can live with it.

Can NPCs spawn inside the supermarket or player house? What happens then? Should we use the nonspawnable space here?

With af02f81b57835816a54fa13ec30ce358038c8038 included your suggestions. Placed panel at same position as in levelgethome (which is also not center!). But I think it looks better now. Player house has a box collider attached for NPCs. They can spawn there but will be immediately pushed to the side. We could use the nonspawnable space, but in my opinion it also works as is.