Johannes/levelmasks

[holke]

AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH

Margrit, i need your help.

I just wanted to merge the new master into this branch in order to be able to build on top of the new levels and properly integrate the mask level.

But i somehow totally messed up :( The player does not enter the house anymore in the get home level. It does if you press space, but then the small player does not look out of the window and the level does not end :/ The same happens in the supermarket level. In the mask level also the mini player does not show up anymore when you press space.

Additionally in the supermarket some NPCs have just stopped moving!

HHEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEELP

Edit: please don’t merge. I forgot to set this to draft.

[maccxs]

I will have a look

[maccxs]

Is the plan that also for these levels, the player has to press space to enter the house?

[maccxs]

All player houses fixed, probably the non-moving sprites in levelsupermarket are due to missing pathfinding project? Can you check if this works in the master for you?

[holke]

Thanks.

Whatever you prefer. In my opinion it felt very Natural in the get Home and Supermarkt Level That the player just enters the house without me needing to do anything.

[maccxs]

I have done it like that

Am Fr., 22. Mai 2020 um 20:05 Uhr schrieb holke notifications@github.com:

Thanks.

Whatever you prefer. In my opinion Infekt very Natural in the get Home and Supermarkt Level That t player just enters the house without me needing to do anything.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/youvsvirus/youvsvirus-unity/pull/117#issuecomment-632833431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXB3RZKHONSN5XCV3RZ743RS25FPANCNFSM4NH7OUVQ .

[maccxs]

Your level is not easy. I really like it. :-) Is ist wanted that the player can move behind the hospital? And the NPCs cannot? Somehow we have to tell the user that they can hide in the house. Really cool!!! :-) :-) :-)

[holke]

Thanks for fixing this :-) Will check whether it works tomorrow.

I am happy that you like the level. And yes it is intended that the player can walk „inside“ the hospital and not the npcs.

To be done:

• inform player that he can enter/exit the house
• move the mask stat to the top right
• ???

[maccxs]

I like the idea that the player can walk into the hospital but during the game it feels like an error since you see the player vanish behind the hospital. Also, the player can hide behind the hospital before NPCs but not really because we do not see his position. Maybe allow him to enter the hospital as well as his own house by pressing space? Otherwise there is nothing to be done. I will have a close look at it when you have finished?

[holke]

Thank you for looking into this and fixing it. The house now behaves as intended.

There are still 4-6 smileys in the supermarket level that are not moving, though. I guess these are the bridge crossing smileys. The pathfinding project folder is in the assets. I also get debug messages like "Path completed. Computation time ... "

[holke]

I like the idea that the player can walk into the hospital but during the game it feels like an error since you see the player vanish behind the hospital. Also, the player can hide behind the hospital before NPCs but not really because we do not see his position. Maybe allow him to enter the hospital as well as his own house by pressing space? Otherwise there is nothing to be done. I will have a close look at it when you have finished?

I now changed it such that the player also collides with the hospital. When all masks are collected and the player collides with the hospital the level finishes.

[holke]

I would consider the mask level to be done now :) Please check and give me some feedback.

What still needs to be fixed before merge are the non-moving NPCs in the supermarket level.

Another point: It is cool that we can enter the house again to be safe for a while. However, since the house is in the corner, we actually never are close to the house to make use of this feature. Would it be worthwhile to change the map such that the house is more in the middle? But, would that not involve having to deal with the rhine and the bridges? So, maybe this is too much a change for now... What is you opinion?

[holke]

Actually, the NPCs in the supermarket are not moving in the master branch as well. So this is propably not related to my merge efforts.

[holke]

Not quite done yet. I just noticed:

• The disco level is not called correcly at the end.
• It would make much more sense if the player needs to get back home after delivering the masks.

[holke]

Also maybe remove the mask counter from the start screen?

[maccxs]

If i leave the house and go a bit aways I cannot get inside again If i leave and do not move away I can get inside

[maccxs]

Will you tell me when you want more feedback on this level, please?

[holke]

Up to the sometimes buggy house and the continue button still leading to the wrong level, this is now really finished (final2_final.exe ;) ) and would appreciate more feedback.

Also, could you elaborate a bit more on the house behavior? How far away do you go until it stops working? And what did you expect to happen instead?

[maccxs]

If I press space to leave and then immediately press space again it works. If I move out of trigger zone and back in it does not.

[maccxs]

I I go to the hospital without any masks, the canvas says "The hospital has enough masks now"

[maccxs]

Can we maybe introduce a test mode for this level where you only have to collect one or two masks? It is quite hard to get all of them to test all functionalities.

[maccxs]

Again and again :-)

[maccxs]

Btw, I still love how hard it is and that I am really invested in getting all the masks, and in the end I am still getting infected. It's really annoying and addicting at the same time.

[holke]

I I go to the hospital without any masks, the canvas says "The hospital has enough masks now"

Argh. I set the needed masks to 0 for debugging, but did not want to push this.

Can we maybe introduce a test mode for this level where you only have to collect one or two masks? It is quite hard to get all of them to test all functionalities.

Yeah, thats why i set it to 0 for myself. You can just change the number in the endlevelcontroller script.

[maccxs]

If I play levelsupermarket, the game sometimes ends early and shows me the statistics end screen... ?

[holke]

If I play levelsupermarket, the game sometimes ends early and shows me the statistics end screen... ?

The one from sandbox mode? mhmm, thats bad

[maccxs]

If I play levelsupermarket, the game sometimes ends early and shows me the statistics end screen... ?

The one from sandbox mode? mhmm, thats bad

Yes, the one from sandbox

[maccxs]

Maybe linked to pressing space? But not sure about that and not always

[maccxs]

Maybe linked to pressing space? But not sure about that and not always

No, not linked to space

[holke]

I guess ill spend my weekend on a "finalfinal_now_finallydone.exe".

[maccxs]

Mostly these seemingly deeply disturbing errors in the game are fixed really quickly in unity

[holke]

The house works better now. However, the trigger enter seems broken. Once we walk away, we cannot enter it :(

[holke]

Still need to activate the nonspawnable space for the mask. Otherwise this is finished now.

[holke]

I declare this to be finished.

[maccxs]

If I am out of the house I cannot get back in

[maccxs]

Why is Press Space called PressSpace(Missing Prefab)

[maccxs]

Nooo, Cant' get out of the house now

[maccxs]

Sorry, you already know I love your level :-)

[holke]

If I am out of the house I cannot get back in

Yes, that is supposed to happen.

[holke]

Nooo, Cant' get out of the house now

Are you inside before the level finished??? That´s not supposed to happen... You should only be able to get inside when you have collected everything and the level should then finish...

[maccxs]

I thought the player was supposed to be able to hide in the house?

[holke]

As i said above, i deactivated this option. I think it confused the player more than it helped in this level. And the player can still "hide" by just standing in the door.

[holke]

Sorry, didnt say it above but in the house discussion thread.

[maccxs]

I think most scripts are now in the same folder as the scenes, you have separated it. What do you prefer?

[maccxs]

I reall like the start screen ;-)

[maccxs]

Should the text at the CanvasSucc get a comma? Congratulations, you made it! Or Congratulations! You made it!

[maccxs]

Maybe rename both folders LevelCollectMasks to levelcollectmasks, I used this since you introduced it when renaming the scenes to StartscreenLevelcollectmasks, etc. ?

[maccxs]

Oh no, the player is missing in the sandbox level now!

[maccxs]

Again, to sum up: Awesome level and lots of work that went into it! I am amazed at your skills of thinking about code reusability and future strategies even in this new and unknown setting :-) Very good job. If we could have the player in the sandbox mode again and if the other minor comments are answered I will be very happy to merge this.

[holke]

Oh no, the player is missing in the sandbox level now!

I just reactivated the player. Should work now.

[holke]

I think most scripts are now in the same folder as the scenes, you have separated it. What do you prefer?

mhmm, i am a bit confused here. We have a folder Scripts, which we should use for scripts. But there are sometimes very level specific scripts und sometimes scripts that were introduced in a level but during develop get the status of scripts that are needed everywhere.

I would suggest that we properly discuss this again after the release and clean up our folder structure.