search

youvsvirus / youvsvirus-unity

Unity version of the you vs virus game.
GNU General Public License v3.0
1 stars 1 forks source link

Added Smiley pictures to the end screen #68

Closed holke closed 4 years ago

holke commented 4 years ago

Next to the numbers in the end screen there are now Smileys to visually indicate the stats.

holke commented 4 years ago

Question: Do we have a place in the repo for data that we want to store but is not a Unity asset? I had to make a pictures of an arrow, which i did as a vector graphic .svg file. To use it in unity i build a .png from it. However, i want to keep the original .svg in case we need to change something later. Currently i store it at the same place as the .png which means that it shows up in the unity editor, showing two arrows (the png and svg). I rather store it somewhere, where it is not picked up by the unity editor...

holke commented 4 years ago

Please review #69 first and if you think it is good, i will put the svg files in the new additional data folder.

holke commented 4 years ago

Yeah i took the wrong colour there. I think both issues would be resolved if i only took the blue smileys (this is also what we actually count: how often did a smiley get blue).

maccxs commented 4 years ago

Taking the blue smileys would be mathematically correct. But I think, it would be still missleading for the user who might ask: And what about the red ones? Where are those counted? It is already a little difficult with this construction and maybe it would be the chance to reference both.

holke commented 4 years ago

mhmmm, okay ill try it.

I thought about this option at first but decided against it, since it will clutter the end screen with smileys and make look too much. But as i said, ill try it.

holke commented 4 years ago

I changed this now and added the player smiley (i thought i already had included it, but it got lost in a commit), and added blue and red smileys to infected.

In my opinion having blue and red smileys makes the end screen look really cluttered and chaotic now. I rather not have the red smileys. Please see 2fdb3ff for the alternative version.

maccxs commented 4 years ago

Hi, yes, I agree. If you did not make any further changes in https://github.com/youvsvirus/youvsvirus-unity/commit/2fdb3ffdc5fca0c7ccaad38eec771322454847a3, that can be merged into master.