search

youvsvirus / youvsvirus-unity

Unity version of the you vs virus game.
GNU General Public License v3.0
1 stars 1 forks source link

More levels #73

Closed holke closed 4 years ago

holke commented 4 years ago

Prepare for multiple level usage.

Changed end game controller to end level controller. Implemented base class for end level controller, so that each level can implement its own end conditions.

You do not need to merge this, but i would love to hear your feedback on this.

holke commented 4 years ago

We now have a second level to try out. It currently does nothing different than the first (except for a supermarket ok the map), but demonstrates that multiple levels work and serves as a template to build levels.

maccxs commented 4 years ago

Moin, really happy that you took this on :-) Fits to my endeavour of building the next level really well! So I have only had a very small look at it, just tried it out. The game ended early in the second level, although no end condition was met. We already had that problem with the end game controller; see the branch and comments there. (and closed issue) Sorry to just leave this quick small dirty feedback, but I have a family date in 1 minute. Will look a lot more later.

holke commented 4 years ago

Thank you for the feedback. The second level is supposed to end early this is not a bug. If you look in the editor at the endlevelcontroller entity, an end time of (I think) 20 seconds is set there. Set it to 0 for the same end conditions as the other level. Have fun with your family ;)

maccxs commented 4 years ago

Hi, I think I like the structure with the EndGameController inheriting for each level from a base. :-)

maccxs commented 4 years ago

Thy for the feedback. The second level is supposed to end early this is not a bug. If you look in the editor at the endlevelcontroller entity, an end time of (I think) 20 seconds is set there. Set it to 0 for the same end conditions as the other level. Have fun with your family ;)

Mmh, I don't see it. in that inherited class it says public class EndLevelControllerLevel2 : EndLevelControllerBase {

} so nothing. Also noticed that the comment says The end level controller for level 1. which should be 2, of course. Did you mean something different?

maccxs commented 4 years ago

Ah, I see, you set it to 10s in the inspector. and in the script you say: everything as in the base class :-)

maccxs commented 4 years ago

Would it make sense to have a similar strucutre for the level initialization? The user will not always be allowed to set #npc and so on... Just a thought