Change our naming scheme for levels

[holke]

We first implemented level3 and then decided to change level3 to level4. This means that we have to rename some ~20 scripts, classes and game objects from "level3" to "level4". This is a tedious and error prone process and we should avoid having to do this again in the future, when we decide to squeeze in another level.

I suggest that we use a different naming scheme for our levels that is more robust against adding new levels in between.

How about:

• The levels have names (i.e. "GetHome", "CollectMasks", "Disco", etc.) and all scripts, scenes and objecst for a level have the corresponding name (instead of "LevelN")
• In a different script we have an array of all these names that specifies the order of levels, i.e. ["GetHome", "Disco", ...], and functions that a level can use to get its successor level. Then for example the endScreen for the "CollectMasks" level does not call

  UnityEngine.SceneManagement.SceneManager.LoadScene("YouVsVirus_Level3");

  but instead something like

  NextLevel = LevelList.GetNextLevel("CollectMasks");
  UnityEngine.SceneManagement.SceneManager.LoadScene(NextLevel);

  • Adding a new level would then only require to write the level name at the correct position in the list and would not need to touch the implementation of other levels.

[holke]

Started by renaming all levels. The names don’t have numbers anymore.

[holke]

I am not done yet xD

[maccxs]

Ups 😬 Ich dachte du wolltest es in zwei requests aufteilen

Von meinem Telefon gesendet

Am 01.05.2020 um 21:08 schrieb holke notifications@github.com:

 I am not done yet xD

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

[holke]

Maybe the merge request closed the issue automatically? I will split this in 2 mr, so it was good that the first mr is merged.

[maccxs]

If you link this to the merge request the mr closes the issue automatically.

[holke]

I see, that’s annoying.

[maccxs]

It would also be possible to use directories for the different scenes which really makes it easier to find stuff. And you do not have to give unity the whole path, it still finds the scene. Maybe we should use directories for the levels and the scripts that belong to the levels in the script and scene folder, respectively.

[holke]

yes we should. It starts to get crowded.

[holke]

This

NextLevel = LevelList.GetNextLevel("CollectMasks"); UnityEngine.SceneManagement.SceneManager.LoadScene(NextLevel); is more or less exactly what we are doing now in the new Menu. It is not necessary to give the level a specific name for this. Unity knows the order form the build settings and we can navigate to the current, next (and previous) level that way.

We still have some if levelname == STRING constructs in the code that i would love to eliminate.