NSFPlug does not respect infinite playback mode

[0x5066]

While subtracks do sort of respect it, the music fades away at 2:30 and stays silent throughout.

[yoyofr]

fixed in v3.5

[0x5066]

Unfortunately it hasn't been fixed, and the issue still occurs.

[yoyofr]

Could you please share some files so that I can test/reproduce the issue? I've just tried and I don't have the issue: I used Castlevania nsfe file from Samples/Game folder. -> after activating infinite playback mode (infinity symbol activated), when a subsong ends/fades out, it reset shortly after and restart from beginning of the subsong.

[0x5066]

I've tested this with "super mario bros 1, 2, vs extra tracks (fds).nsf" from MODLAND (though this affects practically any NSF file). First track always appears with a duration of 2:35, subtracks are then "infinite".

This isn't ideal as there are tracks that exceed the 2:35 length, so them restarting in the middle, or in the case of the Super Mario Bros. NSF, hearing it fade out and suddenly restart from the beginning catch someone off-guard, especially since they'd expect it to play infinitely long with no interruptions.

There is a song by Persune called "Fell", due to Internet issues I can't provide a link to it at this moment, but it is a song that exceeds 2:35 and thus never finishes playing to completion.

[yoyofr]

OK thanks will check

Le lun. 26 févr. 2024 à 12:52, Eris Lund @.***> a écrit :

I've tested this with "super mario bros 1, 2, vs extra tracks (fds).nsf" from MODLAND (though this affects practically any NSF file). First track always appears with a duration of 2:35, subtracks are then "infinite".

This isn't ideal as there are tracks that exceed the 2:35 length, so them restarting in the middle, or in the case of the Super Mario Bros. NSF, hearing it fade out and suddenly restart from the beginning catch someone off-guard, especially since they'd expect it to play infinitely long with no interruptions.

There is a song by Persune called "Fell", due to Internet issues I can't provide a link to it at this moment, but it is a song that exceeds 2:35 and thus never finishes playing to completion.

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/113#issuecomment-1963965642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ5Y56H2LJKWMOFRL7GU63YVRZOLAVCNFSM6AAAAABDQXQWCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTHE3DKNRUGI . You are receiving this because you modified the open/close state.Message ID: @.***>

[0x5066]

fell.zip Here's the NSF file I mentioned

[yoyofr]

Thanks. I have changed the infinite loop behaviour for NSFPlay: it will remove the fadeout allowing gapless looping. Also I will add a specific default length settings in plugins/nsfplay to let you choose default length when not defined in the file itself

Le 26 févr. 2024 à 17:08, Eris Lund @.***> a écrit :

fell.zip https://github.com/yoyofr/modizer/files/14407218/fell.zip Here's the NSF file I mentioned

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/113#issuecomment-1964528532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ5Y53VNEU6SOU6Q4F6CHTYVSXPRAVCNFSM6AAAAABDQXQWCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGUZDQNJTGI. You are receiving this because you modified the open/close state.

[yoyofr]

v3.6 released

[0x5066]

I think providing a Default Length slider is a perfect middle ground (even if I'd prefer it to be longer, like 40 minutes or something, some people are weird like that :) ) for solving the issue, thanks!

[yoyofr]

I've improved the slider component, in v3.7 it will allow to select a wider range of default playtime duration