search

yoyofr / modizer

iOS chiptune/module player
http://yoyofr.blogspot.com/p/modizer.html
132 stars 45 forks source link

3.5 feedback #118

Closed Abster876 closed 1 month ago

Abster876 commented 3 months ago

Hello. I want to provide some feedback for the latest version, 3.5.

NSF infinite playback is still broken. Whenever I turn the infinity switch on the current tune still fades away and ends after 10 minutes. It also displays as a length of 10 minutes. I’ll show a couple pictures to show what’s going on.

BC6282C6-E1BC-49D5-A86F-63179327F3F3 AA5AA95F-754F-48FC-9F35-3D9F7420D510

.imf files (Commander Keen/Duke 2/Wolf 3d) have imperfect instruments no matter which settings I choose in ADPLUG. Perhaps that music driver can use an update?

LIBKSS for MSX tracks has imperfect instruments as well. This happened when the overhaul of MSX playback was implemented some versions back. Perhaps the audio driver for MSX can be reverted back to a previous version?

yoyofr commented 3 months ago

Hi

Thanks for the detailed feedback. V3.6 is almost ready, probably just a few days before I submit it to the appstore for approval.

The nsf infinite playback / fade out issue will be fixed in it.

For imf file, 3.6 will feature a global upgrade of adplug, hopefully it should fix the issue.

Regarding kss, I will try to update the libkss (need to check if a newer version exists) and also add a switch in settings to select between libkss and libgme (the old one).

Rgds ym

Le mar. 5 mars 2024 à 07:19, Abster876 @.***> a écrit :

Hello. I want to provide some feedback for the latest version, 3.5.

NSF infinite playback is still broken. Whenever I turn the infinity switch on the current tune still fades away and ends after 10 minutes. It also displays as a length of 10 minutes. I’ll show a couple pictures to show what’s going on.

BC6282C6-E1BC-49D5-A86F-63179327F3F3.png (view on web) https://github.com/yoyofr/modizer/assets/162279246/824a3dd7-29d5-4c2f-a020-87d006747f9c AA5AA95F-754F-48FC-9F35-3D9F7420D510.png (view on web) https://github.com/yoyofr/modizer/assets/162279246/5ea2fa92-8296-456e-b926-2c00a7bca2b2

.imf files (Commander Keen/Duke 2/Wolf 3d) have imperfect instruments no matter which settings I choose in ADPLUG. Perhaps that music driver can use an update?

LIBKSS for MSX tracks has imperfect instruments as well. This happened when the overhaul of MSX playback was implemented some versions back. Perhaps the audio driver for MSX can be reverted back to a previous version?

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ5Y55QELHY2B46ODZYJ3TYWVPVNAVCNFSM6AAAAABEGQIC7OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3DQMZYG4ZTAOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bri2000 commented 3 months ago

Hello, just installed v3.5 on my new phone, I'm finding a few bugs and I'm confused if the problem might be on my side. Modizer used to work perfect on my old iphone 11, using iphone 15 now.

If I use "add all to playlist", crash to desktop, if I use "add all to now playing" crash to desktop, if I try to add files to a new playlist, "add all" doesn't appear to do anything, "remove all" crashes to desktop.

Is 3.5 broken or is the problem at my side...?

Thank you!

yoyofr commented 3 months ago

it looks like a bug. If I understand well, when you are in the file browser, you try to add the entries to a playlist by clicking on one of the 2 icons at the top (add to playlist or add to now playing). Is it correct ? How many entries do you have ? Would be useful to have a few screenshots

bri2000 commented 3 months ago

That's correct, and it happens no matter how many entries I have.

For example, fresh install. Library>Samples>Various. Only two midi files here. I press +ALL, app crashes. I press the headphones, "listen to all now", app crashes too.

IMG_1764

A different bug, or problem I have. Playlists>select some playlist>add/remove files>samples>various. I press +ALL, nothing happens, they don't get added to playlist. I have to add one by one. I press -ALL, crash to desktop.

IMG_1765

yoyofr commented 3 months ago

it's quite strange. Can you try reseting you settings "in more/maintenance". If still ko, you can try as well "clean database" and "recreate samples folder"

bri2000 commented 3 months ago

It was a fresh install. I tried anyway, the 3 steps you mention, one by one. Crashed each time

bri2000 commented 3 months ago

OK I found the problem. I downloaded the app in my wife's iphone 13, worked perfect as always.

I found the problem was... text size.

IMG_1777

I have the text size in my phone too big. From this notch onwards, the app crashes. Just one notch to the left, modizer works fine.

If you bother to fix it, it would be great 😄 For the time being, I'll just make a text in my phone a bit smaller.

Thank you for everything, I love modizer. Keep up the good work!

yoyofr commented 3 months ago

Ok, thanks for the update. I think I’ve identified the underlying issue, should be able to fix it for v3.6

On Sat 9 Mar 2024 at 21:51, bri2000 @. @.>> wrote:

OK I found the problem. I downloaded the app in my wife's iphone 13, worked perfect as always.

I found the problem was... text size.

IMG_1777.PNG (view on web) https://github.com/yoyofr/modizer/assets/162642893/f7fa9adb-0bcd-4deb-9abe-bb6bdbd0dbfc I have the text size in my phone too big. From this notch onwards, the app crashes. Just one notch to the left, modizer works fine.

If you bother to fix it, it would be great 😄 For the time being, I'll just make a text in my phone a bit smaller.

Thank you for everything, I love modizer. Keep up the good work!

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/118#issuecomment-1986976797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ5Y5Y6D2DREOOMBN6324DYXNY3TAVCNFSM6AAAAABEGQIC7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWHE3TMNZZG4. You are receiving this because you commented.

yoyofr commented 3 months ago

Fixed in current dev build, will be part of v3.6

bri2000 commented 3 months ago

Great!! Thank you!!

El El dom, 17 mar 2024 a las 10:08, yoyofr @.***> escribió:

Fixed in current dev build, will be part of v3.6

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/118#issuecomment-2002372634, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGY3XTJGOZK7QQKPZV2JHG3YYVMPPAVCNFSM6AAAAABEGQIC7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGM3TENRTGQ . You are receiving this because you commented.Message ID: @.***>

yoyofr commented 1 month ago

v3.6 released