yoyofr / modizer

iOS chiptune/module player
http://yoyofr.blogspot.com/p/modizer.html
132 stars 45 forks source link

Support of FLAC audio files #119

Closed tmagri closed 1 month ago

tmagri commented 3 months ago

Since native iOS does not support FLAC. Is there a possibility that modizer can have the ability to play FLAC files. FLAC is outside the scope of chip tune playing, so consider this a nice to have. Thanks for a great player!

yoyofr commented 3 months ago

Have you tried a FLAC file ? It should already be supported 😄

tmagri commented 3 months ago

Hi Yoyofr/Modizer,

Yes, seems the player halts, until I pick a file that is a different format. So I thought possibly unsupported. Tried different flac files all halt when attempt to play.

I am running iOS 17.4.

Thanks!

On Sat, 16 Mar 2024 at 2:23 AM, yoyofr @.***> wrote:

Have you tried a FLAC file ? It should already be supported 😄

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/119#issuecomment-1999897984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA563KQC4LHESLSPU3PLYLDYYMG5NAVCNFSM6AAAAABEOYE7Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHA4TOOJYGQ . You are receiving this because you authored the thread.Message ID: @.***>

yoyofr commented 3 months ago

It seems to work ok in my current dev build (v3.6 beta). Could you please share a file not working in v3.5 so that I can confirm it will work in v3.6?

tmagri commented 3 months ago

A sample file, https://drive.google.com/file/d/1JPTngGxH22awcGYs5SGJL_Q5AxZ0B7fH/view?usp=sharing

as per YouTube video provided link https://youtu.be/xymTUHtRO3U?si=W48e3KDHUxBnPt6l

All Flac files regardless seem to not play on my iPhone 15,

Thanks

jaystermusic commented 3 months ago

Chiming in here. I believe FLAC is supported by VGMStream and it may use FFmpeg to decode, so this may be a similar issue to what happened to opus files. FLAC doesn’t seem to work in 3.5 for me either.

yoyofr commented 3 months ago

Yes, that’s the same issue. It works fine in my dev build, so will ok in v3.6

Le 17 mars 2024 à 14:56, jaystermusic @.***> a écrit :

Chiming in here. I believe FLAC is supported by VGMStream and it may use FFmpeg to decode, so this may be a similar issue to what happened to opus files. FLAC doesn’t seem to work in 3.5 for me either.

— Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/119#issuecomment-2002480124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ5Y5ZE7CIERNZYBN4RKETYYWOHNAVCNFSM6AAAAABEOYE7Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGQ4DAMJSGQ. You are receiving this because you commented.

yoyofr commented 1 month ago

v3.6 released