search

yoyofr / modizer

iOS chiptune/module player
http://yoyofr.blogspot.com/p/modizer.html
132 stars 45 forks source link

USF issues #128

Open Tanookirby opened 3 weeks ago

Tanookirby commented 3 weeks ago

I found more playback issues for the latest version of Modizer. This time, it concerns a few Nintendo 64 files. First, the files for Super Mario 64 cut off around two seconds. Second, the files for the game Mischief Makers play back at a ridiculous speed.

yoyofr commented 3 weeks ago

Please share some files as the issue might be the files dumps.

Tanookirby commented 3 weeks ago

[super mario 64.zip](https://github.com/user-att Mischief Makers.zip achments/files/15593986/super.mario.64.zip) Mischief Makers.zip](https://github.com/user-attachments/files/15593993/Mischief.Makers.zip)

yoyofr commented 3 weeks ago

seems to be twice the same file, mischief makers. I've just tried and the first song sound the same as the game (I used a youtube longplay video to compare). Could you please share more details ? Alternatively did you try to reset your settings in other/maintenance screen ?

Tanookirby commented 3 weeks ago

Resetting did the trick for the second issue. Here are the files for the other game. sm64.zip

Also, it appears that the USF speed changes came from changing the default NSF player to GME.

yoyofr commented 3 weeks ago

ok thanks. for sm64, it seems the lazyusf version I use in modizer doesn't work well with some rerip files. Please use https://usf.joshw.info/s/Super%20Mario%2064%20(1996-06-23)(Nintendo%20EAD)(Nintendo)%5bN64%5d.7z instead, it sounds ok I think (you can access it from modizer in joshw online collection, just be sure to take the file which isn't ending with 'rerip') Issue is the latest version works well for the sm64 rerip version but not for yoshi island for example...

Tanookirby commented 3 weeks ago

What version of lazyusf do you use?

yoyofr commented 3 weeks ago

an older one, not sure to remember which commit I had to rollback on to have yoshi story working. I'll do some tests again. I suspect the C interpreter has some issues that the x86 dynarec hasn't.

yoyofr commented 3 weeks ago

I identified the issue. latest lazyusf2 version has some issues in fpu logic. Also identified an issue with usf files having no length tag. I will release a fix soon, it will improve a lot USF compatibility

Tanookirby commented 1 week ago

Thanks. The problem appears to be resolved.