Closed Sappharad closed 8 years ago
Thanks Paul,
I ll check this asap.
Rgds Ym
Envoyé de mon iPhone
Le 3 oct. 2014 à 20:24, Paul Kratt notifications@github.com a écrit :
I've just forked the latest and committed some really rough (bad) changes that add iPhone 6 support, in case you're interested. I didn't submit a pull request because I'm not sure if you'd want these changes, since some of it was just me fixing compiler errors until the code would build again.
Xcode 6 has a bunch of problems building the current code out of the box. What I ended up doing to get it to build (but didn't include in my check-in because I don't like it and I'm not convinced it was necessary to do) was removing the embedded projects like libgme, libmodplug, etc, and building them separately and including the .a files in the main project instead of sub-projects. Otherwise Xcode 6 seemed to freeze when trying to compile with no errors listed. There was probably a better solution but I was just looking for a quick fix for the zoomed UI.
Anyway, I'm opening this issue for you to add support officially. :-)
— Reply to this email directly or view it on GitHub https://github.com/yoyofr/modizer/issues/23.
I've just forked the latest and committed some really rough (bad) changes that add iPhone 6 support, in case you're interested. I didn't submit a pull request because I'm not sure if you'd want these changes, since some of it was just me fixing compiler errors until the code would build again. https://github.com/Sappharad/modizer/commit/b7649d2654094ce18152623bf632df1966f18dcf (Either way, you probably won't want the splash screen, since I just let Pixelmator's healing tool fill in the missing area for the extra resolution. It looks decent actually, but it's obvious that the squares pattern doesn't match)
Xcode 6 has a bunch of problems building the current code out of the box. What I ended up doing to get it to build (but didn't include in my check-in because I don't like it and I'm not convinced it was necessary to do) was removing the embedded projects like libgme, libmodplug, etc, and building them separately and including the .a files in the main project instead of sub-projects. Otherwise Xcode 6 seemed to freeze when trying to compile with no errors listed. There was probably a better solution but I was just looking for a quick fix for the zoomed UI.
Anyway, I'm opening this issue for you to add support officially. :-)