yoyofr / modizer

iOS chiptune/module player
http://yoyofr.blogspot.com/p/modizer.html
132 stars 45 forks source link

Broken Playlists #35

Closed aitchFactor closed 3 years ago

aitchFactor commented 5 years ago

6142B43B-A771-42FA-A28A-966766E90F0D

Playlists currently have multiple issues.

  1. Playlist items randomly duplicate when playing playlists, quitting, shuffling playlists or refreshing the app.

  2. The “Shuffle & Play” function takes several minutes for large playlists (20+ items) and crashes on extremely large playlists (100+ items).

  3. Playlist items can only be removed one at a time from the playlist viewer, and there is a delay caused by deleting each one that seemingly increases proportionally to the number of items in the playlist, up to several seconds. This makes manually deleting duplicates created by issue 1 tedious and difficult.

I really like this app, it’s basically the only music app I use but playlists have had this issue for years now, including multiple updates, without a fix. I hope you read this and make it a priority to rectify these issues.

yoyofr commented 5 years ago

Hi,

yes, playlists management suffers several bugs in current version. I've fixed most of them in my current WIP version, I will release it in the coming weeks

Le ven. 31 mai 2019 à 02:05, aitchFactor notifications@github.com a écrit :

[image: 6142B43B-A771-42FA-A28A-966766E90F0D] https://user-images.githubusercontent.com/42639410/58672533-c1b37580-838a-11e9-94e1-03cae21ae83b.png

Playlists currently have multiple issues.

1.

Playlist items randomly duplicate when playing playlists, quitting, shuffling playlists or refreshing the app. 2.

The “Shuffle & Play” function takes several minutes for large playlists (20+ items) and crashes on extremely large playlists (100+ items). 3.

Playlist items can only be removed one at a time from the playlist viewer, and there is a delay caused by deleting each one that seemingly increases proportionally to the number of items in the playlist, up to several seconds. This makes manually deleting duplicates created by issue 1 tedious and difficult.

I really like this app, it’s basically the only music app I use but playlists have had this issue for years now, including multiple updates, without a fix. I hope you read this and make it a priority to rectify these issues.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/35?email_source=notifications&email_token=AAJ5Y526VUJFAA7V5QWWENDPYBTU3A5CNFSM4HRORPGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GW266YQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ5Y57KY4X2F2CZGEQRZT3PYBTU3ANCNFSM4HRORPGA .

aitchFactor commented 4 years ago

Thanks for fixing many of these bugs in the latest patch. However playlist items still randomly duplicate in the instances I’ve listed above.

yoyofr commented 4 years ago

Hi,

I need more details as I did not had duplication issues during my tests. Please explain all the steps to trigger duplication and I'll fix it.

Le mer. 4 sept. 2019 00:06, aitchFactor notifications@github.com a écrit :

Thanks for fixing many of these bugs in the latest patch. However playlist items still randomly duplicate in the instances I’ve listed above.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/35?email_source=notifications&email_token=AAJ5Y54MB5HYJCDQ2SNLTCTQH3NUPA5CNFSM4HRORPGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZXBYA#issuecomment-527659232, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ5Y56F335F7OAVHNKJ4BTQH3NUPANCNFSM4HRORPGA .

aitchFactor commented 4 years ago

Garou_-_Mark_of_theWolves(Neo_Geo).zip

  1. Create a new playlist.
  2. Select "Add/Remove files…" and tap the blue » on the file I uploaded.
  3. Tap the purple "+ALL" button.
  4. Navigate back to the playlists viewer (the screen that lists all the playlists you've created)
  5. Tap on the playlist you just created.
  6. Some of the files should be duplicated. Some not at all, but others should be duplicated more than once.
yoyofr commented 4 years ago

Hello

I did follow the steps and did not have duplicated entries. Can you try to reset your DB?(it will remove all your playlists and statistics) it is an option available in the other/maintenance screen. I suspect DB corruption issue caused by previous version.

Rgds ym

Le mer. 4 sept. 2019 à 12:22, aitchFactor notifications@github.com a écrit :

Garou_-Mark_of_the_Wolves(NeoGeo).zip <https://github.com/yoyofr/modizer/files/3574023/Garou-_Mark_of_theWolves.Neo_Geo.zip>

  1. Create a new playlist.
  2. Select "Add/Remove files…" and tap the blue » on the file I uploaded.
  3. Tap the purple "+ALL" button.
  4. Navigate back to the playlists viewer (the screen that lists all the playlists you've created)
  5. Tap on the playlist you just created.
  6. Some of the files should be duplicated. Some not at all, but others should be duplicated more than once.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/35?email_source=notifications&email_token=AAJ5Y54RB6SJG7W37HLOTJ3QH6D77A5CNFSM4HRORPGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53DJ3Q#issuecomment-527840494, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ5Y56VSAYSMGQXDCBIPYDQH6D77ANCNFSM4HRORPGA .

aitchFactor commented 4 years ago

This seems to have fixed the issue. Thanks for your help.

aitchFactor commented 4 years ago

Upon further testing it seems it still occurs in some cases. I’m reopening this in case anyone else has the same issue.

aitchFactor commented 4 years ago

FF17E14F-26C3-4ACA-9A5F-26DC91642CB3 3FFD40F7-6F3B-4CDD-AB3C-74836BBA77BC 86457131-ED0A-42F0-B962-F7F50507442E 3520EAF4-6273-4897-886D-8932567E5312 After resetting DB and offloading/reinstalling app it seems only the items that play are duplicated. Replication steps:

  1. Create a playlist.
  2. Tap on a song in the playlist in the playlist viewer.
  3. Navigate back to the playlists viewer (select the back arrow twice)
  4. Tap on the playlist again. The item previously selected should be the only one duplicated.
aitchFactor commented 4 years ago

7C527A35-AB87-47B8-BACF-431F998866FD

yoyofr commented 4 years ago

Hi,

Ok thanks, I will fix this in next version.

Le mar. 10 sept. 2019 à 06:22, aitchFactor notifications@github.com a écrit :

[image: 7C527A35-AB87-47B8-BACF-431F998866FD] https://user-images.githubusercontent.com/42639410/64583959-6b68c080-d3d6-11e9-8140-11688b4fa652.gif

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/35?email_source=notifications&email_token=AAJ5Y5Y2DOYNXDGDBVDI7ITQI4OJNA5CNFSM4HRORPGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6JYWIY#issuecomment-529763107, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ5Y53Y2S3XIJHZJW6MHPTQI4OJNANCNFSM4HRORPGA .

yoyofr commented 3 years ago

should be fixed in v2.9.4