yoyofr / modizer

iOS chiptune/module player
http://yoyofr.blogspot.com/p/modizer.html
132 stars 45 forks source link

Another USF Tempo Issue #47

Closed Tanookirby closed 3 years ago

Tanookirby commented 3 years ago

First of all, many thanks for solving the infinity loop problem. Now I can insert many more soundtracks without any issues.

About my problem, I noticed certain USF sets are no longer being played at a crazy speed, but now I believe they are being played a bit too slowly. Track rerips like the ones for Super Mario 64 and Mario Kart 64 now play with the slower tempo much like their initial versions. They seem to work perfectly when played in Foobar with the USF Decoder component. So what's going on here?

yoyofr commented 3 years ago

ok thanks for the feedback. I did a quick test and I'm not sure what you mean by modizer playing slightly slowly compared to foobar. I'm using kode54 source code for lazyusf2 which is the same code used in foobar2000 for the USF decoder. The only difference I noticed is that I was not taking into account the fade time at the end of the song. For example mario kart 64 select & setup music is 1:16 long in Foobar2000 (5s of fadeout time) compared to 1:11 in modizer. Also the fadeout time is added to the main time in foobar2000 but there is no real fadeout (progressive decrease of volume) applied to the song. I might add proper fadeout management in modizer in next version. Are you sure the song are played a little bit more slowly in Modizer ? If so I would need a file to test and a reference to compare (youtube link would be perfect)

Tanookirby commented 3 years ago

It would be more like this: https://www.youtube.com/watch?v=da4-9blmg3Y&list=PL354A16B73ABB107D&index=19

yoyofr commented 3 years ago

ok thanks, I will check

Le mer. 3 mars 2021 à 17:56, Tanookirby notifications@github.com a écrit :

It would be more like this: https://www.youtube.com/watch?v=da4-9blmg3Y&list=PL354A16B73ABB107D&index=19

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/yoyofr/modizer/issues/47#issuecomment-789875954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ5Y53CBLMFMDAGVQR6YNLTBZS47ANCNFSM4YP2THIA .

yoyofr commented 3 years ago

ok, that's fixed. I did not use the latest lazyusf library version in v2.9.5. Using the latest one from kode54 it now sounds good. Will try to publish a v2.9.6 quickly, probably this weekend