search

yoyofr / modizer

iOS chiptune/module player
http://yoyofr.blogspot.com/p/modizer.html
132 stars 45 forks source link

Suggestion: in preferences, treat Amiga MODs different from PC MODs #7

Closed mistydemeo closed 12 years ago

mistydemeo commented 12 years ago

Rationale: My personal preference is UADE for Amiga mods, while I find the Dumb provides better playback for the songs I listen to than Modplug does. Since UADE only plays Amiga mods though, the hardcoded fallback means that if I choose UADE as my mod format, all PC songs will play in Modplug. I'd find it convenient to be able to set default player for Amiga and PC formats separately.

Wanted to check in on your opinion before submitting patches.

yoyofr commented 12 years ago

Hi Misty,

I also wanted to review this. Dumb should be used automatically when UADE cannot load files.

At the beginning I did use modplug because I was afraid than Dumb might be too slow for some devices, but these devices cannot allow UADE playback, so there is no question.

I also noticed your pull request to remove animation: I wanted to do some test because I like to have some animations and I'm not sure of how it would look without them. If I don't like it without them I'll implement a switch in the settings under the 'display' panel.

rgds, ym Le 2 mars 2012 à 03:22, Misty De Meo a écrit :

Rationale: My personal preference is UADE for Amiga mods, while I find the Dumb provides better playback for the songs I listen to than Modplug does. Since UADE only plays Amiga mods though, the hardcoded fallback means that if I choose UADE as my mod format, all PC songs will play in Modplug. I'd find it convenient to be able to set default player for Amiga and PC formats separately.

Wanted to check in on your opinion before submitting patches.

Reply to this email directly or view it on GitHub: https://github.com/yoyofr/modizer/issues/7

mistydemeo commented 12 years ago

OK, that's a simple enough moving up of Dumb in the chain - will submit a request.

I actually initiated the pull request because the animations were behaving a little differently in the iOS simulator, and I didn't like them there. They look fine on a real device.

That said, I'd still suggest removing the animation on the Info, X, etc. buttons. I find that the animation on the panel flipping works because it does a good job of visualizing the switch between panels; the metaphor of there being one panel with multiple sides works nicely. The animation on the buttons doesn't appear to have a useful purpose though, and is distracting.