search

yoyololicon / kamui

MIT License
16 stars 4 forks source link

Unwrapping of cyclical data #4

Open nup002 opened 5 months ago

nup002 commented 5 months ago

I would love to give Kamui a try in my particular application where I am tasked with unwrapping weighted gridded data with one cyclical axis. However, I do not understand the algorithm well enough to figure out how to implement cyclical axes. An example of how to unwrap 2D data with one cyclical axis would be highly appreciated. Ideally, this functionality would be part of the library itself with an optional cyclical_axis keyword.

yoyololicon commented 5 months ago

Hi @nup002 , thanks for asking. That sounds like a good idea and can be easily added.

The type of cyclical_axis will be Union[Int, Tuple[Int]], in the case of multiple cyclical axes. I'll find a time to do it.

yoyololicon commented 4 months ago

Hi @nup002,

The cyclical axis feature is added to the dev branch (5ea1b10f0dee2a3700bc55cbe5d95bcdb2c785dc). If you have time, could you help me test if it work in your case.

nup002 commented 4 months ago

Hello @yoyololicon , I am really excited to try this out! I will get back to you once I've had a go at using it, to provide feedback. It may take a few weeks, as we have a lot of higher-priority tasks.