Closed the-mysh closed 1 month ago
I've now added a choice of methods to compute an edge weight from a pair of phase weights: choose from mean, max, and min.
Hi @yoyololicon , thanks for your review. I made changes according to your suggestions. I saw though that in case you use puma, the weights
argument should not be present - so I opted for extracting it from kwargs and adding the prepared weights only if any were originally defined.
Please let me know what you think!
@the-mysh please format the code using black. See the failing workflow for details.
Hi @yoyololicon , sorry for the radio silence, got distracted by other work projects. I've implemented your change requests, please have a look when you get the chance.
Thank @the-mysh, for the contribution! This will be included in the next release v0.1.2
.
Hi @yoyololicon, I think I have figured out a way of passing the weights to the ILP unwrapping.
Please review it; in particular, I was wondering if the rescaling approach and calculating the mean to go from weight-per-phase to weight-per edge is correct.
If it's all right, I think it should resolve #6 which I opened earlier.