search

yoyololicon / pytorch-NMF

A pytorch package for non-negative matrix factorization.
https://pytorch-nmf.readthedocs.io/
MIT License
223 stars 24 forks source link

PLCA wrong regularization update #14

Closed yoyololicon closed 3 years ago

yoyololicon commented 3 years ago

https://github.com/yoyololicon/pytorch-NMF/blob/dce05b2d40262950ab45e48ff30a7ca79589cf86/torchnmf/plca.py#L275

These 6 lines may cause problem when alpha != 1 but params does not require grad and should not be modified.