search

yoyostile / moneymoney-binance

Inofficial Binance Extension (www.binance.com) for MoneyMoney
7 stars 0 forks source link

Binance IOTA shows 0,00 #7

Closed aendes closed 4 years ago

aendes commented 5 years ago

Hello,

since some days there seems to be an issue with binance and IOTA.

My BTC still show a value of > 0,00. My OTA shows the correct amount but with value 0,00.

MoneyMoney Version: 2.3.13 (329)

yoyostile commented 5 years ago

@aendes Is this still broken?

aendes commented 5 years ago

Yes, this is still broken

On Thu, Jun 27, 2019 at 10:12 AM Johannes Heck notifications@github.com wrote:

@aendes https://github.com/aendes Is this still broken?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yoyostile/moneymoney-binance/issues/7?email_source=notifications&email_token=AIOJVMPM6TVGAOYVFZUQIKTP4RY7RA5CNFSM4HQJBZZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWKIRA#issuecomment-506242116, or mute the thread https://github.com/notifications/unsubscribe-auth/AIOJVMMWQBG4UFBVNZNVZZTP4RY7RANCNFSM4HQJBZZQ .

mightyx commented 5 years ago

I also saw this issue. Is this something what we can fix in the extension?

Edit: I think the issue is that we search for "IOT" via the cryptocompare API. But we need to look for "MIOTA":

https://min-api.cryptocompare.com/data/pricemulti?fsyms=ETH,NEO,GAS,IOT,BTG,ADA,XLM,USDC,&tsyms=EUR Here IOTA is missing

https://min-api.cryptocompare.com/data/pricemulti?fsyms=ETH,NEO,GAS,MIOTA,BTG,ADA,XLM,USDC,&tsyms=EUR With this request we get a price

Edit2:

I changed it in line 42:

IOTA = "MIOTA",

for me this fixes the issue.

yoyostile commented 5 years ago

@mightyx thank you for your feedback. fixed this now, waiting for Michael from moneymoney to sign the new version.