yoyurec / logseq-awesome-styler

🎨 Totally customizable theme with presets: colors, backgrounds, fonts and sizes, etc... Logseq plugin
MIT License
185 stars 9 forks source link

FR: Highlight blocks that have sub-blocks #2

Closed benjypng closed 2 years ago

benjypng commented 2 years ago

Great theme! Love it!

Is it possible to have some visual way to highlight blocks that have child blocks? Currently you only see the arrows when you hover over the blocks.

Thanks in advance!

yoyurec commented 2 years ago

Currently in Logseq (and my theme, cose it based on it) you can see "there are childd, man!" via:

yoyurec commented 2 years ago

do you suggest to show arrows always? woudn't it be over complicate design and view?

why you need more signs of child if you see identation and content already? hm... can you explain the reason and idea?

yoyurec commented 2 years ago

like this? image

benjypng commented 2 years ago

Apologies for the late reply! And sorry if I was not more specific. Basically in queries, there are no bullets, so you cannot tell if a particular query item has a dropdown list or not. For example, out of the 4 queries below, the 2nd one actually has sub-bullets. But you can't tell until you hover your mouse over the left hand area. This only applies to query results. For regular blocks, it is fine. [image: Screenshot 2022-05-12 at 10.53.45 PM.png]

On Thu, May 12, 2022 at 10:04 PM Yuriy Piskun @.***> wrote:

like this? [image: image] https://user-images.githubusercontent.com/137919/168093644-38463893-3c46-45c9-b902-6877429fbc9b.png

— Reply to this email directly, view it on GitHub https://github.com/yoyurec/logseq-solarized-extended-theme/issues/2#issuecomment-1125037075, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNXKGLXRGGX3KD5GVHAP2TVJUFWXANCNFSM5VYB5XJQ . You are receiving this because you authored the thread.Message ID: @.***>

yoyurec commented 2 years ago

your sceenshot lost ((

benjypng commented 2 years ago

your sceenshot lost ((

Sorry! Hope it shows now!

Screenshot 2022-05-12 at 11 00 45 PM
yoyurec commented 2 years ago
  1. After you click on arrow - do child expands? mine not (( so see no reason of this feature. can you provide your md code with items and query?
  2. comparing to other blocks - they have attribute hasChild, so arrows can be styled to show always, but in current case - logseq think that there is no childs - hasChilds="false"! image
  3. we can try to show always - but then it will be a mess (( image

Looks like it's a LS bug it attribute, but if after opening it doesn't shows sub-content - then it''s not a bug ) At least with my trying to reproduce your case...

yoyurec commented 2 years ago

wow just spotted nice spec effect with opacity and selecting deep blocks in my theme ))) image

benjypng commented 2 years ago
  1. After you click on arrow - do child expands? mine not (( so see no reason of this feature. can you provide your md code with items and query?
  2. comparing to other blocks - they have attribute hasChild, so arrows can be styled to show always, but in current case - logseq think that there is no childs - hasChilds="false"! image
  3. we can try to show always - but then it will be a mess (( image

Looks like it's a LS bug it attribute, but if after opening it doesn't shows sub-content - then it''s not a bug ) At least with my trying to reproduce your case...

Thanks for sharing! It's ok, small thing. Still love your theme!

yoyurec commented 2 years ago
  1. After you click on arrow - do child expands?

do? )

benjypng commented 2 years ago
  1. After you click on arrow - do child expands?

do? )

Yup it does!

yoyurec commented 2 years ago

hm... and hasChilds="true"? can you send me test .md files so i can reproduce? i need to test. maybe your FR possible...

benjypng commented 2 years ago

Yes, the hasChild="true". It's basically a query, so I am not sure how to send you the .md file.

yoyurec commented 2 years ago

post here as code. items + query