External links to the specific site icon is how to achieve

yoyurec / logseq-awesome-styler

🎨 Totally customizable theme with presets: colors, backgrounds, fonts and sizes, etc... Logseq plugin

MIT License

183 stars 9 forks source link

External links to the specific site icon is how to achieve #25

Closed YangWaldon closed 2 years ago

YangWaldon commented 2 years ago

I have asked you for help explaining how the site icon for external links is implemented, and I would like to add it to my custom. css

yoyurec commented 2 years ago

previously they were done via CSS - https://github.com/yoyurec/logseq-solarized-extended-theme/blob/e1565b05f5eabacedb977b587273bee38da05416/src/custom.css#L404-L470 but it's only for ~20 top sites, and the list is populated manually ((

now i'm using JS version with content editor detections, google favicons API, and CSS variables...

YangWaldon commented 2 years ago

Thank you! ① So, if you want to display all the site icons, it is not feasible to use custom.css only, right? ② Also I have another question, why the code related to Search panel in the theme.css file of the plugin does not work after I copy and paste it into custom.css, Is this functionality also not possible through a pure css solution?

yoyurec commented 2 years ago

1) right. only JS (( 2) it's also done via JS - to rearrange toolbar elements. Their default order too hard and too buggy for CSS job

YangWaldon commented 2 years ago

Okay, thanks for the answer！