yoyurec / logseq-awesome-styler

🎨 Totally customizable theme with presets: colors, backgrounds, fonts and sizes, etc... Logseq plugin
MIT License
183 stars 9 forks source link

Fetch link favicons even when feature disabled #35

Closed constfold closed 2 years ago

constfold commented 2 years ago

Info:

Description: I disabled the "Auto favicons for external links" by using --favicons: none; as there is no network in my work place. But then found there still are request about favicon.

To Reproduce: Disable that feature, input some links, then you would see the network requests.

Expected behavior: Not fetch favicon when auto favicon disabled at all.

Screenshots Snipaste_2022-08-07_16-35-56

Attach files

yoyurec commented 2 years ago

it was "CSS only" solution for disable. now working on JS with configuration via Logseq plugins settings

constfold commented 2 years ago

gotcha. Thanks for your hard work, this is the best logseq theme I ever use

yoyurec commented 2 years ago

DONE! ⚠️ according to theme init changes - RELOAD REQUIRED! ⚠️ https://github.com/yoyurec/logseq-solarized-extended-theme/releases/tag/v2.0.0