search

yoyurec / logseq-awesome-styler

🎨 Totally customizable theme with presets: colors, backgrounds, fonts and sizes, etc... Logseq plugin
MIT License
183 stars 9 forks source link

Is it possible to plug in some of the features in a theme so that they can be used with other themes #36

Closed YangWaldon closed 2 years ago

YangWaldon commented 2 years ago

Because logseq currently has so many themes and each has its own pros and cons, but logseq-solarized-extended-theme is really the best theme I've seen so far. Sometimes I also find that the self-contained theme works well, but when using the default theme, I really want some of the features in the logseq-solarized-extended-theme theme, such as the following image So would the developers consider the possibility of making a separate plugin for these features in that theme, so that it can be used in combination with other themes, which would surely be very popular

yoyurec commented 2 years ago

Extracting features to separate plugin good idea.. BUT some of features (for ex. favicons) too complicated and too connected to theme CSS/JS... Also hard to know other themers UI elements, they styled in different way - i can't cover reseting all their icons and adding my own. When i do feature inside my theme - i'm sure there is no conflicts with styling,

In few days will be release with settings, in a week settings v2 with colors editing - so theme will be not just Solarized ))

About reusing - some theme & plugin devs already insriped by SolExt + i do pull requests to their repos to improve ))

yoyurec commented 2 years ago

@YangWaldon what cons you see in my theme? what pros you see in other themes, missed in my?

YangWaldon commented 2 years ago

I think your theme is the best. At the moment it seems that I would like to be able to use the features you developed in your theme with links automatically adding page icons, resetting toolbars and search boxes and query styles under the default theme of logseq, I don't know if this will be possible in the future

yoyurec commented 2 years ago

under the default theme of logseq

like default font, white color, ... what else? i need a list of most important thing from default theme to not undo every CSS line of SolExt ))

YangWaldon commented 2 years ago

Just add some solarized theme features to the default theme, other things like homepage width, color, font, size, etc. don't need to be changed.