yoyurec / logseq-awesome-styler

🎨 Totally customizable theme with presets: colors, backgrounds, fonts and sizes, etc... Logseq plugin
MIT License
183 stars 9 forks source link

The search box is incomplete #38

Closed YangWaldon closed 2 years ago

YangWaldon commented 2 years ago

As you can see below, there is a section of the search box that doesn't drop down and looks cut off image

yoyurec commented 2 years ago

it's 2 separated elements - search "button" and search popup. according to different amount of plugins it's width CSS fixed to some "median" value. so it's not cutted, but just not responsive.

in next versions will try to set both width equal.

YangWaldon commented 2 years ago

Ok, equal width would look better, please tell me when the next version will be released

yoyurec commented 2 years ago

few days )

yoyurec commented 2 years ago

Fixed! ⚠️ according to theme init changes - RELOAD REQUIRED! ⚠️ https://github.com/yoyurec/logseq-solarized-extended-theme/releases/tag/v2.0.0

YangWaldon commented 2 years ago

Just updated the theme plugin, have a few questions ① The width of the right sidebar can not be manually adjusted, as shown below image

② Is it no longer possible to modify the background color in custom.css, I hope to add the option to modify the color as soon as possible

yoyurec commented 2 years ago
  1. are u sure? image

  2. yes, colors options will be added in few days try to disable custom css

YangWaldon commented 2 years ago

are u sure?

I'm pretty sure that when I set both widths in Settings > Plugin Settings > solarized plugin settings, after the maximum width is set to a larger one, say 2000 or 1800, the right hand side bar won't open because the main page width doesn't automatically narrow, which is equivalent to squeezing the right hand side bar out

yoyurec commented 2 years ago

theme just overwrites DEFAULT logseq variables

can you say app width and theme width settings to reproduce? maybe it can be fixed somehow, but as i said - no Logseq logic was touched.

YangWaldon commented 2 years ago

① After trying the default theme for a day, I just switched back to the solarized theme and found that the width of the sidebar can be adjusted again ------ image

② I also found a problem that when I first switched to the solarized theme, the icon to open the right sidebar did not appear, it only appeared after I opened the right sidebar with a shortcut image image

③ Will you be able to adjust the background color of the main page, the left column and the right column after the color adjustment option is introduced in the future? I like the background color of the default theme very much

YangWaldon commented 2 years ago

One more issue to report, the bold style is not working. Just to clarify, I added the following code to custom.css to change the bold style, which works fine in other themes, but not in the solarized theme imageimage

image

yoyurec commented 2 years ago

i think you can use different issues for different bugs )

yoyurec commented 2 years ago

③ Will you be able to adjust the background color of the main page, the left column and the right column after the color adjustment option is introduced in the future? I like the background color of the default theme very much

there will be:

yoyurec commented 2 years ago

One more issue to report, the bold style is not working. Just to clarify, I added the following code to custom.css to change the bold style, which works fine in other themes, but not in the solarized theme imageimage

image

there is bold, but thin )) 500 instead of default 700 (text with 700 looks blurry)

BTW, are you using custom font in Logseq? this one image

and this one (windows custom font?) image

YangWaldon commented 2 years ago

③ Will you be able to adjust the background color of the main page, the left column and the right column after the color adjustment option is introduced in the future? I like the background color of the default theme very much

there will be:

  • content bg (main content +right sidebar content clocks) color
  • and UI bg (head+sidebars+tabs) image

In other words, in the image below, the color of the area where the arrow is pointing can be changed, right? image

YangWaldon commented 2 years ago

BTW, are you using custom font in Logseq?

Yes, I'm using a custom font in custom.css image

yoyurec commented 2 years ago

In other words, in the image below, the color of the area where the arrow is pointing can be changed, right?

yes ) image

yoyurec commented 2 years ago

BTW, are you using custom font in Logseq?

Yes, I'm using a custom font in custom.css image

then before you submit bug it will be good to check is it appears with "untouched" SolExt. i can't support your customizations ))

yoyurec commented 2 years ago

In other words, in the image below, the color of the area where the arrow is pointing can be changed, right?

yes ) image

6 editable colors + 8 autogenareted shades from them (for borders, deep block levels, alt text color, etc...) 😎

YangWaldon commented 2 years ago

then before you submit the bug it will be good to check is it appears with "untouched" SolExt. i can't support your customizations ))

So the reason the bold style is not working is because I'm using a custom font? And this bug is not fixable, right?

yoyurec commented 2 years ago

bold was maked thinner and with FiraSans font looked better (in your font bold-notbold diff almost minor). will revert on next release...