yoyurec / logseq-banners-plugin

136 stars 11 forks source link

Quote is showing tag marks #68

Closed compadrejunior closed 1 year ago

compadrejunior commented 1 year ago

Hi, folks.

Since version 3.4.8, my banner is show the tags marks in quotes. The problem is even worse when the quote is inside a #BEGIN_QUOTE #END_QUOTE mark.

Here's an example:

image

How do I solve this?

Thanks in advance.

Best regards.

José Compadre Junior

sawhney17 commented 1 year ago

For the quotes, make sure you change the regex from the current to this. (^(TODO|NOW))|([a-z-]+::[^]*)|(SCHEDULED:.<.*>)|([[)|(]])|(#[w-_+]+)

You can do so from settings.

Alternatively, you can rebuild the regex through the command palette Rebuild Regex for Banner Plugin On 24 Jan 2023 at 10:34 PM +0400, José Compadre Junior @.***>, wrote:

Hi, folks. Since version 3.4.8, my banner is show the tags marks in quotes. The problem is even worse when the quote is inside a #BEGIN_QUOTE #END_QUOTE mark. Here's an example: How do I solve this? Thanks in advance. Best regards. José Compadre Junior — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

sawhney17 commented 1 year ago

Command pallete is accessible through command shift p On 24 Jan 2023 at 10:38 PM +0400, Aryan Sawhney @.***>, wrote:

For the quotes, make sure you change the regex from the current to this. (^(TODO|NOW))|([a-z-]+::[^]*)|(SCHEDULED:.<.*>)|([[)|(]])|(#[w-_+]+)

You can do so from settings.

Alternatively, you can rebuild the regex through the command palette Rebuild Regex for Banner Plugin On 24 Jan 2023 at 10:34 PM +0400, José Compadre Junior @.***>, wrote:

Hi, folks. Since version 3.4.8, my banner is show the tags marks in quotes. The problem is even worse when the quote is inside a #BEGIN_QUOTE #END_QUOTE mark. Here's an example: How do I solve this? Thanks in advance. Best regards. José Compadre Junior — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

compadrejunior commented 1 year ago

Hello, @sawhney17

Thanks for your reply.

I tried with the given regex but it generates the following console error:

banners.ts:839 Uncaught (in promise) SyntaxError: Invalid regular expression: /(^(TODO|NOW))|([a-z-]+::[^]*)|(SCHEDULED:.<.*>)|([[)|(]])|(#[w-_+]+)/: Range out of order in character class (at banners.ts:839:25) at new RegExp (<anonymous>) at jr (banners.ts:839:25) at async kr (banners.ts:786:17)

Alternatively I've tried the following regex and it works fine.

(^(TODO|NOW))|([a-z-]+::[^]*)|(SCHEDULED:.<.*>)|([[)|(]])|(\#quote)|(\#\+BEGIN_QUOTE)|(\#\+END_QUOTE)

Best regards,

José Compadre Junior