cant (re)name AMsynth midi or jack port names

[GoogleCodeExporter]

What steps will reproduce the problem?
1. start jack
2. start AMsynth
3. start a second AMsynth

What is the expected output? What do you see instead?

no real problem, but it seems that the jack ports of AMsynth get a unique 
identifier starting from 130 (131 for the second AMsynth, 132 for the third ...)
This is ok, but i'm running a setup with 4 AMsynth instances and routing in 
jack can get confusing at times

some other synths provide a (cli) option to customize the port names
eg : phasex has the -n option to do this
this makes it a lot easier to identify the ports

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by thijsvan...@gmail.com on 20 Nov 2013 at 11:31

[GoogleCodeExporter]

I've attached a patch that adds 'n' as a command line switch and uses the 
argument as the JACK client name.  Is this useful enough, or should it be 
changeable after the instance starts as well?

Original comment by joshua.t...@gmail.com on 22 Dec 2013 at 11:21

Attachments:

• changeable_jack_client_name.diff

[GoogleCodeExporter]

Hi Nick,

sounds perfect for me!
i'll try it asap

Thanks a lot !!

Thijs

Original comment by thijsvan...@gmail.com on 23 Dec 2013 at 10:56

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

hi Nick

i finally found some time to test the patch, and it seems to work as expected 
:-)
i did notice a small typo in JackOutput.cc on line 70 : "amysnth" iso "amsynth"

thanx man !

grtz
Thijs

btw: is this patch going to be applied on the main branch ?  (and thus be 
available in your PPA?)

Original comment by thijsvan...@gmail.com on 7 Jan 2014 at 12:03

[GoogleCodeExporter]

Hi Thijs,

I'm not Nick - I probably should have signed my comment with a name up there.  
I just love amSynth and saw the opportunity to contribute this straightforward 
patch.  I have no idea when/if he'll chose to apply the patch to the main repo.

Josh

Original comment by joshua.t...@gmail.com on 10 Jan 2014 at 3:32

[GoogleCodeExporter]

oops, hi Josh :-)
well thanks for your patch ! 
come to think of it, i was a bit surprised that Nick attached a patch iso just 
making the change directly in the code, so i should have known :-S

guess it's up to Nick to decide
i can confirm that the patch works as expected

grtz
Thijs

Original comment by thijsvan...@gmail.com on 10 Jan 2014 at 10:43

[GoogleCodeExporter]

Sorry for the delay, and thanks for the patch & feedback - it has now been 
applied.

Original comment by nickdowell on 3 Feb 2014 at 8:17

• Changed state: Fixed
• Added labels: Type-Enhancement
• Removed labels: Type-Defect