search

yoyz / picoloop

96 stars 9 forks source link

the tuning of note are not ok on master ( picoloop 0.74x) picoloop 0.69 ok #18

Closed yoyz closed 8 years ago

yoyz commented 8 years ago

picoloop 0.69 ok

yoyz commented 8 years ago

picoloop 0.70 ok picoloop 0.71 ok picoloop 0.72 ok picoloop 0.73 pbsynth ko

The sound is detune slightly... Can not be heard, if it is not close to another instrument.... So master branch is ko on this side, all instrument were tuned to a bad instrument....

yoyz commented 8 years ago

FIXED in tag "picoloop-0.74d"

The MonoMixer.{h,cpp} has an optimization which break the tuning of note. So Here I reput the old MonoMixer and set back the tuning. The optimization of MonoMixer will be put again and double checked, because it slightly outdetune some synth. This optimization is usefull on small hardware because it try to avoid ICache and Dcache trashing.

For info, I use a guitar tuner to double check the audio tuning of the synth, and it seem to be okay now. This one was really hard to find and to fix.

yoyz commented 8 years ago

Fix in 0.74d