search

yozik04 / nextion

Nextion serial client
GNU Lesser General Public License v3.0
25 stars 10 forks source link

Support for multiple character encodings #6

Closed Chronocento closed 4 years ago

Chronocento commented 4 years ago

See https://github.com/yozik04/nextion/issues/4

I just noticed that you created version 1.5: I tried to uninstall version 1.4, with which I was working with and made the changes for, and install the new version with pip (with no cache option), but it is still installing version 1.4. Here I tried to repropose the same changes that I did for version 1.4, but at this point, the changes for version 1.5 are not tested.

The idea is that after the connection, the user is able to change the encoding by calling client.set_encoding('encoding-type'); I thought about including the ability to change encoding only once when the connection is created, but I envisioned situations where the user doesn't know which kind of encoding is used by the screen, and gets it from a custom variable after the connection to the screen is set.

yozik04 commented 4 years ago

Implemented different way. Sorry =)