search

yozik04 / nibe-mqtt

Nibe MQTT integration to use with HomeAssistant MQTT Autodiscovery
GNU General Public License v3.0
26 stars 8 forks source link

Unnecessary dependency to pandas #6

Closed lassi-niemisto closed 1 year ago

lassi-niemisto commented 1 year ago

Both nibe library and nibe-mqtt service seem to have an unnecessary dependency to pandas in their requirements.txt.

This makes installing them a nightmare for exotic targets and of course unnecessary is always unnecessary.

Unless I have missed something, the dependency line could be removed. At least basic operation works just fine without pandas.

yozik04 commented 1 year ago

setup.cfg has pandas in extras only. I verified what was installed in virtualenv. I do not see that pandas was installed with simple pip3 install nibe. requirements.txt should list all possible dependencies.

lassi-niemisto commented 1 year ago

Ok, seems I understood the installation procedure a little wrong and missed the fact the packages are actually in pypi repository, ready to install.